cgould/lingo
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Mutable fields should not be public static

Browse Source
This commit is contained in:
Charles Gould 2017-02-08 19:57:57 -05:00
parent 663d0e7e37
commit 573b8d14c4
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
common/src/main/java/lingo/common/Game.java
View File

@ -11,7 +11,6 @@ public class Game {
public static final int INCORRECT_POSITION = 1; public static final int INCORRECT_POSITION = 1;
public static final int CORRECT_CHARACTER = 2; public static final int CORRECT_CHARACTER = 2;
public static final int WORD_LENGTH = 5; public static final int WORD_LENGTH = 5;
public static final int[] INVALID_GUESS = new int[] { 9, 9, 9, 9, 9 };
private static final AtomicInteger idCounter = new AtomicInteger(0); private static final AtomicInteger idCounter = new AtomicInteger(0);
@ -43,6 +42,10 @@ public class Game {
return -1; return -1;
} }
private static int[] invalidGuess() {
return new int[] { 9, 9, 9, 9, 9 };
}
public static boolean isCorrect(int[] result) { public static boolean isCorrect(int[] result) {
for (int i = 0; i < WORD_LENGTH; i++) { for (int i = 0; i < WORD_LENGTH; i++) {
if (result[i] != CORRECT_CHARACTER) { if (result[i] != CORRECT_CHARACTER) {
@ -54,7 +57,7 @@ public class Game {
public int[] evaluate(String guess) { public int[] evaluate(String guess) {
if (!acceptableGuesses.contains(guess)) { if (!acceptableGuesses.contains(guess)) {
return INVALID_GUESS; return invalidGuess();
} }
// the guess is acceptable // the guess is acceptable