From 573b8d14c40a4e6fb605c47bd005d72bb07303da Mon Sep 17 00:00:00 2001 From: Charles Gould Date: Wed, 8 Feb 2017 19:57:57 -0500 Subject: [PATCH] Mutable fields should not be public static --- common/src/main/java/lingo/common/Game.java | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/common/src/main/java/lingo/common/Game.java b/common/src/main/java/lingo/common/Game.java index 2e3e4fb..86aeaac 100644 --- a/common/src/main/java/lingo/common/Game.java +++ b/common/src/main/java/lingo/common/Game.java @@ -11,7 +11,6 @@ public class Game { public static final int INCORRECT_POSITION = 1; public static final int CORRECT_CHARACTER = 2; public static final int WORD_LENGTH = 5; - public static final int[] INVALID_GUESS = new int[] { 9, 9, 9, 9, 9 }; private static final AtomicInteger idCounter = new AtomicInteger(0); @@ -43,6 +42,10 @@ public class Game { return -1; } + private static int[] invalidGuess() { + return new int[] { 9, 9, 9, 9, 9 }; + } + public static boolean isCorrect(int[] result) { for (int i = 0; i < WORD_LENGTH; i++) { if (result[i] != CORRECT_CHARACTER) { @@ -54,7 +57,7 @@ public class Game { public int[] evaluate(String guess) { if (!acceptableGuesses.contains(guess)) { - return INVALID_GUESS; + return invalidGuess(); } // the guess is acceptable